Templates
Uncategorized
Safety Culture Pull Request checklist

Safety Culture Pull Request checklist

1
Is the code understandable?
2
Does the code fit the purpose it was intended for?
3
Have any configuration additions or changes been added to the configuration service already?
4
Are dependencies on other changes clearly specified (or preferably avoided)
5
Has it had a secondary review from someone familiar with the service or technology if needed?
6
If package.json was changed, has shrink wrap been rerun?
7
Does the code contain adequate logging for troubleshooting production issues?
8
Are any new features hidden behind a feature flag or other restriction?
9
Will production features continue working if feature flags are disabled?
10
Does it have adequate unit tests for new code, or add testing for existing code?
11
Is the code able to be deployed into production now?