{"id":11618,"date":"2017-07-20T13:40:21","date_gmt":"2017-07-20T13:40:21","guid":{"rendered":"https:\/\/www.process.st\/templates\/pull-request-review-failed-procedure\/"},"modified":"2024-02-28T20:45:54","modified_gmt":"2024-02-28T20:45:54","slug":"pull-request-review-failed-procedure","status":"publish","type":"post","link":"https:\/\/www.process.st\/templates\/pull-request-review-failed-procedure\/","title":{"rendered":"Pull Request Review Failed Procedure"},"content":{"rendered":"<section id=\"introduction\">\n<h2> Introduction: <\/h2>\n<div class=\"text-content\">\n<p>This checklist describes the procedure for a developer to follow if their pull request has failed review. It involves thoroughly addressing the reasons for rejection, replying with information showing how you've re-tested and solved the problems, and then re-assigning the issue to a manager for a 2nd review.<\/p>\n<p>This simple process is most often used as part of the training and onboarding process at Process Street, and isn't commonly run more than a few times because it's easy to learn.<\/p>\n<p>See also our <a href=\"https:\/\/www.process.st\/templates\/github-pull-request-procedure\" rel=\"nofollow noopener\" target=\"_blank\">GitHub pull request process<\/a>.<\/p>\n<\/p><\/div>\n<\/section>\n<section id=\"reply-to-every-comment-made-in-the-github-pr\">\n<h2> Reply to every comment made in the GitHub PR <\/h2>\n<div class=\"text-content\">\n<p>Make sure that you reply to every comment that was added to the GitHub PR.<\/p>\n<p>This is so we can be sure that all issues were addressed and so that if anyone else looks at the PR, they will understand how the issues were resolved.<\/p>\n<p>Include a link to the pull request in the field below:<\/p>\n<\/p><\/div>\n<\/section>\n<section id=\"reply-to-every-related-comment-made-in-the-jira-issue\">\n<h2> Reply to every related comment made in the JIRA issue <\/h2>\n<div class=\"text-content\">\n<p>Sometimes there are also comments in the JIRA issue. Make sure that these have also been addressed.<\/p>\n<p>Link to the JIRA issue below:<\/p>\n<\/p><\/div>\n<\/section>\n<section id=\"if-this-is-a-fullstack-issue-make-sure-youve-checked-be-and-fe\">\n<h2> If this is a full-stack issue, make sure you've checked BE and FE <\/h2>\n<div class=\"text-content\">\n<p>This is also a common mistake. Make sure you've update both the BE and FE PRs to reflect any necessary changes.<\/p>\n<\/p><\/div>\n<\/section>\n<section id=\"retest-all-the-functionality\">\n<h2> Re-test all the functionality <\/h2>\n<div class=\"text-content\">\n<p><strong>This is important.<\/strong><\/p>\n<p>Many times after implementing fixes during review, we accidentally break the functionality that we just added or fixed.<\/p>\n<p><strong>Please take time to re-test everything that you added, and make notes in the field below:<br \/><\/strong><\/p>\n<\/p><\/div>\n<div class=\"textarea-field-content form-field-content\">\n<div class=\"form-group\">\n   <label> Tests ran: <\/label><br \/>\n   <textarea placeholder=\"Something will be typed here...\" rows=\"3\" disabled=\"disabled\" class=\"form-control\"><\/textarea>\n  <\/div>\n<\/p><\/div>\n<\/section>\n<section id=\"move-issue-to-review-column-in-jira-and-assign-this-task-to-same-reviewer\">\n<h2> Move issue to Review column in JIRA and assign this task to same reviewer <\/h2>\n<\/section>\n<section id=\"attach-this-completed-checklist-as-a-comment-on-the-jira--github-issues\">\n<h2> Attach this completed checklist as a comment on the JIRA &amp; GitHub issues <\/h2>\n<div class=\"text-content\">\n<p>JIRA issue: {{form.JIRA_issue_URL}}<\/p>\n<p>GitHub PR: {{form.Pull_request_URL}}<\/p>\n<p>URL of this checklist: {{checklist.url}}<\/p>\n<\/p><\/div>\n<\/section>\n<section id=\"sources\">\n<h2> Sources: <\/h2>\n<div class=\"text-content\">\n<p><a href=\"https:\/\/www.process.st\" rel=\"nofollow noopener\" target=\"_blank\">Process Street<\/a> - <a href=\"https:\/\/www.process.st\/agile-processes\/\" rel=\"nofollow noopener\" target=\"_blank\">The 11 Agile Processes We Use to Run an Efficient Software Tea<\/a><\/p>\n<\/p><\/div>\n<\/section>\n<section id=\"related-checklists\">\n<h2> Related checklists: <\/h2>\n<div class=\"text-content\">\n<ul>\n<li><a href=\"https:\/\/www.process.st\/templates\/daily-standup-meeting-checklist\/\" rel=\"nofollow\">Daily Standup Meeting Checklist<\/a><\/li>\n<li><a href=\"https:\/\/www.process.st\/templates\/github-pull-request-procedure\/\" rel=\"nofollow\">GitHub Pull Request Procedure<\/a><\/li>\n<li><a href=\"https:\/\/www.process.st\/templates\/sprint-turnover-process\" rel=\"nofollow\">Sprint Turnover Process<\/a><\/li>\n<li><a href=\"https:\/\/www.process.st\/templates\/sprint-retrospective-process\/\" rel=\"nofollow\">Sprint Retrospective Process<\/a><\/li>\n<li><a href=\"https:\/\/www.process.st\/templates\/sprint-estimation-process\/\" rel=\"nofollow\">Sprint Estimation Process<\/a><\/li>\n<li><a href=\"https:\/\/www.process.st\/templates\/sprint-planning\/\" rel=\"nofollow\">Sprint Planning Process<\/a><\/li>\n<li><a href=\"https:\/\/www.process.st\/templates\/scrum-project-management\/\" rel=\"nofollow\">Scrum Project Management<\/a><\/li>\n<li><a href=\"https:\/\/www.process.st\/templates\/git-workflow\/\" rel=\"nofollow\">Git Workflow<\/a><\/li>\n<li><a href=\"https:\/\/www.process.st\/templates\/user-story-template\/\" rel=\"nofollow\">User Story Template<\/a><\/li>\n<li><a href=\"https:\/\/www.process.st\/templates\/software-deployment\/\" rel=\"nofollow\">Software Deployment<\/a><\/li>\n<li><a href=\"https:\/\/www.process.st\/templates\/software-testing-tutorial\/\" rel=\"nofollow\">Software Testing Tutorial<\/a><\/li>\n<li><a href=\"https:\/\/www.process.st\/templates\/software-debugging-process\/\" rel=\"nofollow\">Software Debugging Process<\/a><\/li>\n<\/ul><\/div>\n<\/section>\n","protected":false},"excerpt":{"rendered":"<p>Introduction: This checklist describes the procedure for a developer to follow if their pull request has failed review. It involves thoroughly addressing the reasons for rejection, replying with information showing how you've re-tested and solved the problems, and then re-assigning the issue to a manager for a 2nd review. This simple process is most often [&hellip;]<\/p>\n","protected":false},"author":3,"featured_media":0,"comment_status":"closed","ping_status":"open","sticky":false,"template":"","format":"standard","meta":{"_acf_changed":false,"ep_exclude_from_search":false,"cover_icon_emoji":"","cover_icon_url":"","tasks_count":"9","template_description":"Use this process to solve the problems with your failed pull request review.","template_id":"vgM2WlM9gQZZA6-zfqVFqg","task_0":"Introduction:","task_slug_0":"introduction","task_1":"Reply to every comment made in the GitHub PR","task_slug_1":"reply-to-every-comment-made-in-the-github-pr","task_2":"Reply to every related comment made in the JIRA issue","task_slug_2":"reply-to-every-related-comment-made-in-the-jira-issue","task_3":"If this is a full-stack issue, make sure you've checked BE and FE","task_slug_3":"if-this-is-a-fullstack-issue-make-sure-youve-checked-be-and-fe","task_4":"Re-test all the functionality","task_slug_4":"retest-all-the-functionality","task_5":"Move issue to Review column in JIRA  and assign this task to same reviewer","task_slug_5":"move-issue-to-review-column-in-jira-and-assign-this-task-to-same-reviewer","task_6":"Attach this completed checklist as a comment on the JIRA &amp; GitHub issues","task_slug_6":"attach-this-completed-checklist-as-a-comment-on-the-jira--github-issues","task_7":"Sources:","task_slug_7":"sources","task_8":"Related checklists:","task_slug_8":"related-checklists","task_9":"","task_slug_9":"","task_10":"","task_slug_10":"","task_11":"","task_slug_11":"","task_12":"","task_slug_12":"","task_13":"","task_slug_13":"","task_14":"","task_slug_14":"","task_15":"","task_slug_15":"","task_16":"","task_slug_16":"","task_17":"","task_slug_17":"","task_18":"","task_slug_18":"","task_19":"","task_slug_19":"","task_20":"","task_slug_20":"","task_21":"","task_slug_21":"","task_22":"","task_slug_22":"","task_23":"","task_slug_23":"","task_24":"","task_slug_24":"","task_25":"","task_slug_25":"","task_26":"","task_slug_26":"","task_27":"","task_slug_27":"","task_28":"","task_slug_28":"","task_29":"","task_slug_29":"","task_30":"","task_slug_30":"","task_31":"","task_slug_31":"","task_32":"","task_slug_32":"","task_33":"","task_slug_33":"","task_34":"","task_slug_34":"","task_35":"","task_slug_35":"","task_36":"","task_slug_36":"","task_37":"","task_slug_37":"","task_38":"","task_slug_38":"","task_39":"","task_slug_39":"","task_40":"","task_slug_40":"","task_41":"","task_slug_41":"","task_42":"","task_slug_42":"","task_43":"","task_slug_43":"","task_44":"","task_slug_44":"","task_45":"","task_slug_45":"","task_46":"","task_slug_46":"","task_47":"","task_slug_47":"","task_48":"","task_slug_48":"","task_49":"","task_slug_49":"","task_50":"","task_slug_50":"","task_51":"","task_slug_51":"","task_52":"","task_slug_52":"","task_53":"","task_slug_53":"","task_54":"","task_slug_54":"","task_55":"","task_slug_55":"","task_56":"","task_slug_56":"","task_57":"","task_slug_57":"","task_58":"","task_slug_58":"","task_59":"","task_slug_59":"","task_60":"","task_slug_60":"","task_61":"","task_slug_61":"","task_62":"","task_slug_62":"","task_63":"","task_slug_63":"","task_64":"","task_slug_64":"","task_65":"","task_slug_65":"","task_66":"","task_slug_66":"","task_67":"","task_slug_67":"","task_68":"","task_slug_68":"","task_69":"","task_slug_69":"","task_70":"","task_slug_70":"","task_71":"","task_slug_71":"","task_72":"","task_slug_72":"","task_73":"","task_slug_73":"","task_74":"","task_slug_74":"","task_75":"","task_slug_75":"","task_76":"","task_slug_76":"","task_77":"","task_slug_77":"","task_78":"","task_slug_78":"","task_79":"","task_slug_79":"","task_80":"","task_slug_80":"","task_81":"","task_slug_81":"","task_82":"","task_slug_82":"","task_83":"","task_slug_83":"","task_84":"","task_slug_84":"","task_85":"","task_slug_85":"","task_86":"","task_slug_86":"","task_87":"","task_slug_87":"","task_88":"","task_slug_88":"","task_89":"","task_slug_89":"","task_90":"","task_slug_90":"","task_91":"","task_slug_91":"","task_92":"","task_slug_92":"","task_93":"","task_slug_93":"","task_94":"","task_slug_94":"","task_95":"","task_slug_95":"","task_96":"","task_slug_96":"","task_97":"","task_slug_97":"","task_98":"","task_slug_98":"","task_99":"","task_slug_99":"","footnotes":""},"categories":[7,1],"tags":[],"class_list":["post-11618","post","type-post","status-publish","format-standard","hentry","category-miscellaneous","category-uncategorized"],"acf":[],"aioseo_notices":[],"_links":{"self":[{"href":"https:\/\/www.process.st\/templates\/wp-json\/wp\/v2\/posts\/11618","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/www.process.st\/templates\/wp-json\/wp\/v2\/posts"}],"about":[{"href":"https:\/\/www.process.st\/templates\/wp-json\/wp\/v2\/types\/post"}],"author":[{"embeddable":true,"href":"https:\/\/www.process.st\/templates\/wp-json\/wp\/v2\/users\/3"}],"replies":[{"embeddable":true,"href":"https:\/\/www.process.st\/templates\/wp-json\/wp\/v2\/comments?post=11618"}],"version-history":[{"count":0,"href":"https:\/\/www.process.st\/templates\/wp-json\/wp\/v2\/posts\/11618\/revisions"}],"wp:attachment":[{"href":"https:\/\/www.process.st\/templates\/wp-json\/wp\/v2\/media?parent=11618"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/www.process.st\/templates\/wp-json\/wp\/v2\/categories?post=11618"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/www.process.st\/templates\/wp-json\/wp\/v2\/tags?post=11618"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}